-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MultiRoot Workspace support #663
Open
filip131311
wants to merge
6
commits into
main
Choose a base branch
from
@Filip131311/FixMultiRootWorkspaces
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced Oct 29, 2024
filip131311
added a commit
that referenced
this pull request
Nov 22, 2024
This PR add a possibility to reboot the reboot device, metro and devtools processes without triggering clean build. It was previously only possible by closing and reopening the IDE panel itself. This also will provide necessary functionality for #663 ### How Has This Been Tested: - run an application and pick "Reboot IDE" option from reload dropdown menu
kmagiera
added a commit
that referenced
this pull request
Dec 16, 2024
This PR changes a way we manage build caches. Previous approach was dependent on current vscode workspace, which led to build caches not being accessible when switching from working in the root of the workspace to the root of the application (or doing the same in reverse). The new approach saves this data in global storage, and adds a appRoot identifier to the cache key. This PR is a dependency for #663 ### How Has This Been Tested: - Open a project in the root of the workspace and run some application that is part of it in the IDE. - Open IDE in the root of that application and see if the build cache is loaded. - repeat the proces in reverse - open an application that had a build made before this change and check if migration process works as expected Verify that the build cache migration work: - Build project without these changes - Open the same project with no changes but with the new version of extension – expect the cache hit for native build --------- Co-authored-by: Krzysztof Magiera <[email protected]>
filip131311
changed the title
Draft of MultiRoot Workspace support
MultiRoot Workspace support
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors how we handle the
appRoot
to allow for changing it in runtime.Additionally we enhance the Lunch Configuration View to allow the user for selecting the appRoot from the list.
How has dis been tested?
Run the mono repo with 2 application and switch between them.
Screen.Recording.2024-12-19.at.17.08.49.mov